Skip to content

Conversation

@jmpesp
Copy link
Contributor

@jmpesp jmpesp commented Apr 15, 2022

Remove alpine block dev so that after the global images PR lands, there
isn't a boot device conflict.

@smklein
Copy link
Contributor

smklein commented Apr 15, 2022

Finallly!

@jmpesp
Copy link
Contributor Author

jmpesp commented Apr 21, 2022

I'm wary of merging this, as it will disrupt other's workflows - anyone have thoughts about this?

@smklein
Copy link
Contributor

smklein commented Apr 21, 2022

Do we have images that we can host in the lab / on s3? As long as we make it low-effort to "pick an easy default", I think moving forward here seems like the right move.

FWIW, by changing the SMF file, we're basically modifying the expectations for "propolis when run by the control plane", but not really changing the developer experience for "propolis when built/run standalone".

@jmpesp
Copy link
Contributor Author

jmpesp commented Apr 21, 2022

Do we have images that we can host in the lab / on s3? As long as we make it low-effort to "pick an easy default", I think moving forward here seems like the right move.

FWIW, by changing the SMF file, we're basically modifying the expectations for "propolis when run by the control plane", but not really changing the developer experience for "propolis when built/run standalone".

You're right w.r.t running via the control plane vs standalone. The problem here is that files can be hosted in the lab or s3 but Nexus needs to construct the volume out of something. Developers will have different image definitions for their house vs the lab but if they didn't set that up this PR means they can't boot as easily anymore.

Thinking about this more, what we may need in addition to this PR is documenting how to add /opt/oxide/propolis-server/blob/alpine.iso the "global images" table " as a (not yet implemented) file source. Crucible supports this, we (read: I) just need to teach Nexus about it. That would be the new easy default :)

@smklein
Copy link
Contributor

smklein commented Apr 21, 2022

I think I mostly agree with that reasoning - I'd add, however, that if the "create image from URL" path works well, it would be easy to just host whatever images we want at a well-known location. We could even pre-populate Nexus with this info on startup.

That seems like it would avoid the need for developers to download any images "out-of-band", they'd just get 'em through the normal "download as URL" mechanism.

@jmpesp
Copy link
Contributor Author

jmpesp commented Apr 25, 2022

Thinking about this more, what we may need in addition to this PR is documenting how to add /opt/oxide/propolis-server/blob/alpine.iso the "global images" table " as a (not yet implemented) file source. Crucible supports this, we (read: I) just need to teach Nexus about it.

Opened oxidecomputer/omicron#975 to do this.

Remove alpine block dev so that after the global images PR lands, there
isn't a boot device conflict.
@jmpesp jmpesp merged commit 1538f78 into oxidecomputer:master Jun 1, 2022
@jmpesp jmpesp deleted the no_more_alpine branch June 1, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants