Skip to content

Conversation

@gjcolombo
Copy link
Contributor

(4/X in the PR series for #735.)

Move more code around:

  • Move InstanceEnsureRequest parsing to its own module.
  • Move the rest of the config TOML parsing logic (specifically surrounding device names) into the config_toml module.
  • Shift some types around to allow parsed storage/network device descriptions to be shared between these modules.

There are still relatively few functional changes here, but getting all these modules onto the common "parsed device" types lays most of the remaining foundation for having an "internal" spec type that can take the place of the server's use of InstanceSpecV0.

Tests: cargo test, PHD (still no breaking changes to the API... yet!).

@gjcolombo gjcolombo requested a review from hawkw August 19, 2024 16:25
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me --- I assume you intend to address the things you've already left comments on?

@gjcolombo
Copy link
Contributor Author

Yup! Just need to get my nose out of the RFDs I'm editing :)

@gjcolombo gjcolombo merged commit 64350cd into master Aug 20, 2024
@gjcolombo gjcolombo deleted the gjcolombo/instance-spec-rework-4 branch August 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants