Add workspace and github action #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This should cover building, testing, formatting and docs (though "doc warnings" are ignored). Happy to add any extra checks you'd like, but this seems to be working. Also, making a single workspace to build everything is sorta the easiest option - even locally (rather than running tons of separate checks for different sub-projects). |
Contributor
Author
|
Also: I dunno how familiar you are with GitHub tooling, but FWIW, these checks will not stop us from merging. Branch protection is an option in "Settings" (to which I do not have access; happy to set it up if I get added). |
Contributor
|
I don't think we need branch protection or anything like that for now. The checks on a PR should be adequate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.