Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making an unrelated change to the RFD API, and while setting up my local environment I encountered a few papercuts that would be nice to have fixed:
log_formatwas present inrfd-apibut not inrfd-processor, forcing the use of the JSON logs there. I added the option to it, making sure to maintain backward compatibility with old configuration files.While making the previous change, I noticed that
rfd-apicontained a lot of code to manually deserialize the log format. I switched that enum to the serde derive.Running the migrations,
schema.rswas updated with a whitespace diff and a bunch of tables fromv-api. I modifieddiesel.tomlto ensure there is zero diff when running migrations.While doing so, I noticed the migrations directory field didn't exist, so I removed it to avoid future confusion.
Updated the setup instructions to mention the correct way to run database migrations, as discussed on Matrix.