Skip to content

Conversation

@chantra
Copy link
Contributor

@chantra chantra commented Mar 3, 2023

Cherry-picked the rerun-failed-jobs action from an up-to-date spec. I did not include the enable_debug_logging parameter has it was not currently present with the existing re_run_workflow endpoint.

re-run on failed job doc: https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#re-run-failed-jobs-from-a-workflow-run
Generated diff after make github: https://gist.github.com/chantra/c30751e00fe6034a4ace4ac73646afc6#file-gist-diff-L702

Cherry-picked the `rerun-failed-jobs` action from an up-to-date spec.
I did not include the `enable_debug_logging` parameter has it was not
currently present with the existing `re_run_workflow` endpoint.

re-run on failed job doc: https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#re-run-failed-jobs-from-a-workflow-run
Generated diff after `make github`: https://gist.github.com/chantra/c30751e00fe6034a4ace4ac73646afc6#file-gist-diff-L702
@chantra
Copy link
Contributor Author

chantra commented Mar 3, 2023

I did not include the generated libs as for some reason my toochain still introduce those &var.to_string() changes.

Also, I am not able to actually sync the spec as a whole currently so took this shortcut.

@augustuswm
Copy link
Contributor

Cool thanks! I generally pull and build these changes to check them, so no need to include the generated files.

You are correct that the generator won't build against the current API spec, for a number of reasons. That is something I'm working on. The &var.to_string() lines come from how the generator is implemented. They can be cleaned up with clippy, but that takes a long time to run.

@chantra
Copy link
Contributor Author

chantra commented Mar 4, 2023

That is something I'm working on.

Great. I gave it a look, but it was quite complicated 😁

The &var.to_string() lines come from how the generator is implemented. They can be cleaned up with clippy, but that takes a long time to run.

I believe we can nip it in the bud here:

"crate::progenitor_support::encode_path(&{}_.to_string()),",
to_snake_case(n)
));
} else {
out.push_str(&format!(
"crate::progenitor_support::encode_path(&{}.to_string()),",

@chantra
Copy link
Contributor Author

chantra commented Mar 9, 2023

@augustuswm let me know if there is anything that looks off in this PR. Happy to iterate.

@augustuswm
Copy link
Contributor

Looks good. Merging this and I'll get a release put together.

@augustuswm augustuswm merged commit 979f81b into oxidecomputer:main Mar 10, 2023
kavin-kr pushed a commit to kavin-kr/third-party-api-clients that referenced this pull request Mar 28, 2023
Cherry-picked the `rerun-failed-jobs` action from an up-to-date spec.
I did not include the `enable_debug_logging` parameter has it was not
currently present with the existing `re_run_workflow` endpoint.

re-run on failed job doc: https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#re-run-failed-jobs-from-a-workflow-run
Generated diff after `make github`: https://gist.github.com/chantra/c30751e00fe6034a4ace4ac73646afc6#file-gist-diff-L702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants