Make identity op on julia v1.10 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 98.43% 95.45% -2.99%
==========================================
Files 1 1
Lines 64 66 +2
==========================================
Hits 63 63
- Misses 1 3 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oxinabox
commented
Mar 29, 2023
Pull Request Test Coverage Report for Build 4550113720
💛 - Coveralls |
aviatesk
reviewed
Mar 29, 2023
aviatesk
reviewed
Mar 29, 2023
Comment on lines
-66
to
+83
| static_methods(@nospecialize(f)) = static_methods(f, Tuple{Vararg{Any}}) | ||
| @generated function static_methods(@nospecialize(f) , @nospecialize(_T::Type{T})) where {T <: Tuple} | ||
| list_of_methods = _methods(f, T) | ||
| ci = create_codeinfo_with_returnvalue([Symbol("#self#"), :f, :_T], [:T], (:T,), :($list_of_methods)) | ||
|
|
||
| # Now we add the edges so if a method is defined this recompiles | ||
| ci.edges = _method_table_all_edges_all_methods(f, T) | ||
| return ci | ||
| const static_methods = if VERSION >= v"1.10.0-DEV.609" | ||
| # feature is now built in | ||
| methods | ||
| else | ||
| _static_methods(@nospecialize(f)) = static_methods(f, Tuple{Vararg{Any}}) | ||
| @generated function _static_methods(@nospecialize(f) , @nospecialize(_T::Type{T})) where {T <: Tuple} | ||
| list_of_methods = _methods(f, T) | ||
| ci = create_codeinfo_with_returnvalue([Symbol("#self#"), :f, :_T], [:T], (:T,), :($list_of_methods)) | ||
|
|
||
| # Now we add the edges so if a method is defined this recompiles | ||
| ci.edges = _method_table_all_edges_all_methods(f, T) | ||
| return ci |
There was a problem hiding this comment.
methods isn't constant folded at compile-time even after the PR. It returns vector, which is currently not handled as constant within our compiler.
oxinabox
commented
Mar 29, 2023
|
It's hard to overstate my satisfaction. |
|
Yay! I am so happy about this!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to JuliaLang/julia#48639 we no longer need this package.
We do want to keep it working for purposes of compatibility.
Which is what this PR achieves.
(Also: I win. I got this feature into the language.
This was a triumph. I am making a note here, huge success!)