Skip to content

fix for julia v1.12 edge format changes #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2025
Merged

fix for julia v1.12 edge format changes #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dc0d52
fix for julia v1.12 edge format changes
chengchingwen Jan 11, 2025
03302c5
better VERSION for branching
chengchingwen Jan 11, 2025
7627c31
insert latestworld
chengchingwen Jan 12, 2025
a513a2e
bump version
chengchingwen Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Tricks"
uuid = "410a4b4d-49e4-4fbc-ab6d-cb71b17b3775"
authors = ["Frames White"]
version = "0.1.9"
version = "0.1.10"

[compat]
julia = "1.0"
Expand Down
6 changes: 5 additions & 1 deletion src/Tricks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,11 @@ function _method_table_all_edges_all_methods(f, T, world = Base.get_world_counte

# We add an edge to the MethodTable itself so that when any new methods
# are defined, it recompiles the function.
mt_edges = Core.Compiler.vect(mt, Tuple{f,Vararg{Any}})
@static if VERSION < v"1.12.0-DEV.1531"
mt_edges = Core.Compiler.vect(mt, Tuple{f,Vararg{Any}})
else
mt_edges = Core.Compiler.vect(Tuple{f, Vararg{Any}}, mt)
end

# We want to add an edge to _every existing method instance_, so that
# the deletion of any one of them will trigger recompilation of the function.
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ end
@test static_method_count(j) == 2

@test (length ∘ collect ∘ static_methods)(j, Tuple{Int}) == 1
@test static_method_count(j, Tuple{Int,Int}) == 1
@test static_method_count(j, Tuple{Int}) == 1
@test (length ∘ collect ∘ static_methods)(j, Tuple{Int,Int}) == 1
@test static_method_count(j, Tuple{Int,Int}) == 1
@test (length ∘ collect ∘ static_methods)(j, Tuple{Int,Int,Int}) == 1
Expand Down Expand Up @@ -158,7 +158,7 @@ end

while length(collect(methods(j))) > 0
Base.delete_method((first ∘ methods)(j))

@static isdefined(Core, Symbol("@latestworld")) && Core.@latestworld
T = Tuple{Any, Vararg{Any}}
@test (length ∘ collect ∘ static_methods)(j, T) == length(collect(methods(j)))
@test static_method_count(j, T) == length(collect(methods(j)))
Expand Down
Loading