Skip to content

Conversation

@DarrylGamroth
Copy link
Contributor

  • Use Meta.lower for Julia 1.13+ as jl_expand no longer exists

@coveralls
Copy link

coveralls commented Oct 31, 2025

Pull Request Test Coverage Report for Build 19009558008

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 95.181%

Totals Coverage Status
Change from base Build 16829275534: 0.06%
Covered Lines: 79
Relevant Lines: 83

💛 - Coveralls

@DarrylGamroth DarrylGamroth force-pushed the fix/julia-1.13-meta-lower branch from 3d17b7d to 8dbcbcf Compare October 31, 2025 21:26
@oxinabox
Copy link
Owner

oxinabox commented Nov 2, 2025

Can we have a CI matrix entry created for 1.12 to make sure we didn't break the old functionality?

Comment on lines 19 to 20
- "1.11"
- "~1.12.0-rc1"
Copy link
Owner

@oxinabox oxinabox Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to stay.
Or become 1.11 + 1.12
(and add nightly)

because we need to make sure we do not break old versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Shouldn't "1" be adequate to cover the latest release (1.12.1)? It would probably be best to include 1.10 as it's LTS over using 1.11.
Let me know and I'll update the pull request. Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what 1 refers to will change over time.
Where as 1.12 won't.
It's probably best to keep testing 1.12 as we had to make changes between for 1.12 support
seperately to the changes for 1.10

We could also test LTS.
But IIRC nothing changed for this between 1.3 and 1.10 as far as this is concerned.

I am not too stressed about this.
But i would rather not drop 1.11 testing,
nor 1.12 testing.

As I know people run this in production systems
and the version they can be on can run a bit behind the latest release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you; I added 1.11, 1.12 back.

@oxinabox
Copy link
Owner

oxinabox commented Nov 2, 2025

thank you

* Use Meta.lower for Julia 1.13+ as jl_expand no longer exists
@DarrylGamroth DarrylGamroth force-pushed the fix/julia-1.13-meta-lower branch from 8dbcbcf to ac1e89d Compare November 2, 2025 09:15
@oxinabox oxinabox merged commit 17c26a2 into oxinabox:master Nov 2, 2025
7 checks passed
@oxinabox
Copy link
Owner

oxinabox commented Nov 2, 2025

thank you,
tagging a release presently

@DarrylGamroth DarrylGamroth deleted the fix/julia-1.13-meta-lower branch November 2, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants