-
Notifications
You must be signed in to change notification settings - Fork 14
Update create_codeinfo_with_returnvalue #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create_codeinfo_with_returnvalue #49
Conversation
DarrylGamroth
commented
Oct 31, 2025
- Use Meta.lower for Julia 1.13+ as jl_expand no longer exists
Pull Request Test Coverage Report for Build 19009558008Details
💛 - Coveralls |
3d17b7d to
8dbcbcf
Compare
|
Can we have a CI matrix entry created for 1.12 to make sure we didn't break the old functionality? |
| - "1.11" | ||
| - "~1.12.0-rc1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to stay.
Or become 1.11 + 1.12
(and add nightly)
because we need to make sure we do not break old versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Shouldn't "1" be adequate to cover the latest release (1.12.1)? It would probably be best to include 1.10 as it's LTS over using 1.11.
Let me know and I'll update the pull request. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what 1 refers to will change over time.
Where as 1.12 won't.
It's probably best to keep testing 1.12 as we had to make changes between for 1.12 support
seperately to the changes for 1.10
We could also test LTS.
But IIRC nothing changed for this between 1.3 and 1.10 as far as this is concerned.
I am not too stressed about this.
But i would rather not drop 1.11 testing,
nor 1.12 testing.
As I know people run this in production systems
and the version they can be on can run a bit behind the latest release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thank you; I added 1.11, 1.12 back.
|
thank you |
* Use Meta.lower for Julia 1.13+ as jl_expand no longer exists
8dbcbcf to
ac1e89d
Compare
|
thank you, |