SQLLite.Net.Test.Win32 failing in CreateUniqueIndexes() at CheckIndex(db, indexes, "UX_Uno_bool", true, "Cuatro");

[IanMercer]

Trying to get the unit tests to run locally and I'm seeing several fail including the CreateUniqueIndexes test where the index uses named parameters:

        [Indexed(Name = "UX_Uno_bool", Unique = true)]
        public int Cuatro { get; set; }

The GetIndices() method fails because there are no ConstructorArguments. attribute has two NamedArguments but no ConstructorArguments.

public static IEnumerable<IndexedAttribute> GetIndices(MemberInfo p)
    {
        var indexedAttributes = new List<IndexedAttribute>();
        foreach (var attribute in p.CustomAttributes)
        {
            if (attribute.AttributeType == typeof(IndexedAttribute))
            {
                var arguments = attribute.ConstructorArguments;
                var name = (string)arguments[0].Value;                    <---- EXCEPTION HERE
                var order = (int)arguments[1].Value;
                indexedAttributes.Add(new IndexedAttribute(name, order));
            }
        }
        return indexedAttributes;
      }

[oysteinkrog]

I can confirm that this test fails for me as well.
Unfortunately I don't have time right now to look into this, if anyone that knows the sqlite-net code base can help I would be grateful.

[eugenioestrada]

Hi,

The issue is at the class TableMapping in that code:

var cols = new List<Column>();
foreach (PropertyInfo p in props)
{
    bool ignore = p.GetType().GetTypeInfo().CustomAttributes.Count(attr => attr.AttributeType == typeof(IgnoreAttribute)) > 0;

    if (p.CanWrite && !ignore)
    {
        cols.Add(new Column(p, createFlags));
    }
}

When you use the GetType of 'p' you're getting the Type of PropertyInfo so the Attributtes you will check are the attributes of the BCL PropertyInfo class. So... you can fix this issue replacing this line:

bool ignore = p.GetType().GetTypeInfo().CustomAttributes.Count(attr => attr.AttributeType == typeof(IgnoreAttribute)) > 0;

With:

bool ignore = p.CustomAttributes.Count(attr => attr.AttributeType == typeof(IgnoreAttribute)) > 0;

Enjoy!

[redent]

The proposed fix won't work with IgnoredAttribute subclasses where the old code worked as expected:

bool ignore = p.GetCustomAttributes(typeof (IgnoreAttribute), true).Length > 0;

To adjust the code to the new PCL profile, this is enough:

bool ignore = p.GetCustomAttributes(typeof(IgnoreAttribute), true).Count() > 0;

[oysteinkrog]

I see that I messed up a bit here with the issues, the ignore problem is not related to this issue after all.
Thanks for the fixes for the Ignore bug though, I've applied it and also closed #64.