-
Notifications
You must be signed in to change notification settings - Fork 10
[expo] improve support for flutter native ios dependencies #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tried to run this quickly by checking out the
I also noticed that you're removing the does that mean we'll end up with an iOS and android folder again (so far I'm able to clean up on prebuild)? |
expo-flutter/ios/Podfile
Outdated
use_expo_modules! | ||
# @generated begin expo-flutter-view - expo prebuild (DO NOT MODIFY) sync-a6fad925eb19db4b427cb412b9bf06f47580494d | ||
pod 'Flutter', :podspec => '../modules/expo-flutter-view/ios/Flutter/Flutter.podspec' | ||
pod 'FlutterPluginRegistrant', path: '/Users/mazhnik/Codes/p-mazhnik/flutter-embedding/expo-flutter/modules/expo-flutter-view/ios/Flutter/plugins/FlutterPluginRegistrant' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full path leaked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I fixed it in the latest commits, squash and merge will prevent this from going to the main branch.
I also noticed that you're removing the --clean flag
I just don't think the clean
flag is needed for each change. It takes a long time for me to reinstall all pod dependencies when using clean
, and it is unnecessary to use it every time (although not prohibited)
xcodebuild: error: The workspace named "expoflutter" does not contain a scheme named "ExpoFlutter".
hm, I am looking at the PR changes and don't see anything related. I can quickly setup build in GH Actions to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working with scheme written in lower case: https://github.com/p-mazhnik/flutter-embedding/actions/runs/11011828146/job/30576763675
--scheme expoflutter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this is changed by the PR, and locally I still have scheme with upper case letters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I lost it when I ran prebuild with --clean
Fixes #16