Skip to content

Conversation

p-mazhnik
Copy link
Owner

Fixes #16

@p-mazhnik p-mazhnik marked this pull request as ready for review September 22, 2024 18:40
@p-mazhnik p-mazhnik mentioned this pull request Sep 22, 2024
@p-mazhnik p-mazhnik changed the title improve support for flutter native ios dependencies [expo] improve support for flutter native ios dependencies Sep 22, 2024
@joernroeder
Copy link

tried to run this quickly by checking out the expo-ios-deps branch but got the following error.

CommandError: Failed to build iOS project. "xcodebuild" exited with error code 65.
To view more error logs, try building the app with Xcode directly, by opening ./expo-flutter/ios/expoflutter.xcworkspace.

Command line invocation:
/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace ./expo-flutter/ios/expoflutter.xcworkspace -configuration Debug -scheme ExpoFlutter -destination id=665B6112-96DB-4850-A456-D5F05AD521D2

User defaults from command line:
IDEPackageSupportUseBuiltinSCM = YES

xcodebuild[24047:33845983] Writing error result bundle to /var/folders/1v/ql40bh0n42df7pyrl01d32100000gp/T/ResultBundle_2024-23-09_19-12-0010.xcresult
xcodebuild: error: The workspace named "expoflutter" does not contain a scheme named "ExpoFlutter". The "-list" option can be used to find the names of the schemes in the workspace.

I also noticed that you're removing the --clean flag, https://github.com/p-mazhnik/flutter-embedding/pull/17/files#diff-6da0e730d49be64cf3afe029cbe017c8c50fd8cfee58fa2b8ff4bccc2bdfc7d2L113.

does that mean we'll end up with an iOS and android folder again (so far I'm able to clean up on prebuild)?

use_expo_modules!
# @generated begin expo-flutter-view - expo prebuild (DO NOT MODIFY) sync-a6fad925eb19db4b427cb412b9bf06f47580494d
pod 'Flutter', :podspec => '../modules/expo-flutter-view/ios/Flutter/Flutter.podspec'
pod 'FlutterPluginRegistrant', path: '/Users/mazhnik/Codes/p-mazhnik/flutter-embedding/expo-flutter/modules/expo-flutter-view/ios/Flutter/plugins/FlutterPluginRegistrant'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full path leaked

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I fixed it in the latest commits, squash and merge will prevent this from going to the main branch.

I also noticed that you're removing the --clean flag

I just don't think the clean flag is needed for each change. It takes a long time for me to reinstall all pod dependencies when using clean, and it is unnecessary to use it every time (although not prohibited)

xcodebuild: error: The workspace named "expoflutter" does not contain a scheme named "ExpoFlutter".

hm, I am looking at the PR changes and don't see anything related. I can quickly setup build in GH Actions to check

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with scheme written in lower case: https://github.com/p-mazhnik/flutter-embedding/actions/runs/11011828146/job/30576763675
--scheme expoflutter

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this is changed by the PR, and locally I still have scheme with upper case letters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I lost it when I ran prebuild with --clean

@p-mazhnik p-mazhnik merged commit 483e065 into main Oct 7, 2024
1 check passed
@p-mazhnik p-mazhnik deleted the expo-ios-deps branch October 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

native deps

2 participants