Skip to content

Conversation

@glaubinix
Copy link
Member

No description provided.

@glaubinix glaubinix self-assigned this Sep 9, 2025
@glaubinix glaubinix requested a review from a team September 9, 2025 10:38
@IgorBenko IgorBenko self-requested a review September 10, 2025 08:28
Copy link
Contributor

@IgorBenko IgorBenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already reads really nicely. Below few suggestions

glaubinix and others added 3 commits September 10, 2025 11:41
Co-authored-by: Igor Benko <igor.benko@gmail.com>
Co-authored-by: Igor Benko <igor.benko@gmail.com>
@glaubinix glaubinix requested a review from IgorBenko September 10, 2025 10:45
Copy link
Contributor

@IgorBenko IgorBenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this now looks good! Should we leave this open for someone else to read it, or can we merge?

@glaubinix
Copy link
Member Author

Considering that you reviewed most of the PRs. Let me ping @stevenrombauts to take a look too to make sure this all makes sense to someone not 100% familiar with it.

Copy link
Contributor

@stevenrombauts stevenrombauts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all very clear to me 👍

@stevenrombauts stevenrombauts merged commit f8b1406 into main Sep 10, 2025
@stevenrombauts stevenrombauts deleted the trusted-publishing branch September 10, 2025 12:18
@glaubinix
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants