feat(utils): integral_string? as module_function

Author: sanemat

lib/env_pull_request/utils.rb

@@ -3,5 +3,6 @@ module Utils
     def integral_string?(value)
       value.is_a?(String) && /^\d+$/ =~ value ? true : false
     end
+    module_function :integral_string?
   end
 end

test/test_ci.rb

@@ -30,14 +30,18 @@ def self.shutdown
         test '#pull_request?' do
           assert do
             EnvPullRequest.new do
-              ENV['PULL_REQUEST_ID'].to_i if ENV['PULL_REQUEST_ID']
+              if Utils.integral_string? ENV['PULL_REQUEST_ID']
+                ENV['PULL_REQUEST_ID'].to_i
+              end
             end.pull_request? == false
           end
         end
         test '#pull_request_id' do
           assert do
             EnvPullRequest.new do
-              ENV['PULL_REQUEST_ID'].to_i if ENV['PULL_REQUEST_ID']
+              if Utils.integral_string? ENV['PULL_REQUEST_ID']
+                ENV['PULL_REQUEST_ID'].to_i
+              end
             end.pull_request_id.nil?
           end
         end
@@ -58,14 +62,18 @@ def self.shutdown
         test '#pull_request?' do
           assert do
             EnvPullRequest.new do
-              ENV['PULL_REQUEST_ID'].to_i if ENV['PULL_REQUEST_ID']
+              if Utils.integral_string? ENV['PULL_REQUEST_ID']
+                ENV['PULL_REQUEST_ID'].to_i
+              end
             end.pull_request? == true
           end
         end
         test '#pull_request_id' do
           assert do
             EnvPullRequest.new do
-              ENV['PULL_REQUEST_ID'].to_i if ENV['PULL_REQUEST_ID']
+              if Utils.integral_string? ENV['PULL_REQUEST_ID']
+                ENV['PULL_REQUEST_ID'].to_i
+              end
             end.pull_request_id == pull_id
           end
         end

test/test_utils.rb

@@ -2,41 +2,37 @@
 
 module EnvPullRequest
   class TestUtils < Test::Unit::TestCase
-    target = Class.new do
-      include Utils
-    end.new
-
     sub_test_case 'not integral' do
       test 'nil' do
         assert do
-          target.integral_string?(nil) == false
+          Utils.integral_string?(nil) == false
         end
       end
       test 'empty string' do
         assert do
-          target.integral_string?('') == false
+          Utils.integral_string?('') == false
         end
       end
       test 'integer' do
         assert do
-          target.integral_string?(1) == false
+          Utils.integral_string?(1) == false
         end
       end
       test 'decimal string' do
         assert do
-          target.integral_string?('1.1') == false
+          Utils.integral_string?('1.1') == false
         end
       end
     end
     sub_test_case 'integral' do
       test '1' do
         assert do
-          target.integral_string?('1') == true
+          Utils.integral_string?('1') == true
         end
       end
       test '10000000000000000' do
         assert do
-          target.integral_string?('10000000000000000') == true
+          Utils.integral_string?('10000000000000000') == true
         end
       end
     end