Skip to content

Commit 8bb55b8

Browse files
committed
feat(natural_number_string): update api
1 parent 9722f73 commit 8bb55b8

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

lib/env_pull_request/base.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ def initialize(&block)
1313
end
1414

1515
def fetch_pull_request_id
16-
if natural_number_string? ENV['TRAVIS_PULL_REQUEST']
16+
if positive_integer_string? ENV['TRAVIS_PULL_REQUEST']
1717
ENV['TRAVIS_PULL_REQUEST'].to_i
18-
elsif natural_number_string? ENV['CIRCLE_PR_NUMBER']
18+
elsif positive_integer_string? ENV['CIRCLE_PR_NUMBER']
1919
ENV['CIRCLE_PR_NUMBER'].to_i
20-
elsif natural_number_string? ENV['ghprbPullId']
20+
elsif positive_integer_string? ENV['ghprbPullId']
2121
ENV['ghprbPullId'].to_i
2222
end
2323
end

test/test_own_ci.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def self.shutdown
3030
assert do
3131
EnvPullRequest.new do
3232
if NaturalNumberString
33-
.natural_number_string? ENV['PULL_REQUEST_ID']
33+
.positive_integer_string? ENV['PULL_REQUEST_ID']
3434
ENV['PULL_REQUEST_ID'].to_i
3535
end
3636
end.pull_request? == false
@@ -40,7 +40,7 @@ def self.shutdown
4040
assert do
4141
EnvPullRequest.new do
4242
if NaturalNumberString
43-
.natural_number_string? ENV['PULL_REQUEST_ID']
43+
.positive_integer_string? ENV['PULL_REQUEST_ID']
4444
ENV['PULL_REQUEST_ID'].to_i
4545
end
4646
end.pull_request_id.nil?
@@ -64,7 +64,7 @@ def self.shutdown
6464
assert do
6565
EnvPullRequest.new do
6666
if NaturalNumberString
67-
.natural_number_string? ENV['PULL_REQUEST_ID']
67+
.positive_integer_string? ENV['PULL_REQUEST_ID']
6868
ENV['PULL_REQUEST_ID'].to_i
6969
end
7070
end.pull_request? == true
@@ -74,7 +74,7 @@ def self.shutdown
7474
assert do
7575
EnvPullRequest.new do
7676
if NaturalNumberString
77-
.natural_number_string? ENV['PULL_REQUEST_ID']
77+
.positive_integer_string? ENV['PULL_REQUEST_ID']
7878
ENV['PULL_REQUEST_ID'].to_i
7979
end
8080
end.pull_request_id == pull_id
@@ -94,7 +94,7 @@ def self.shutdown
9494
assert do
9595
EnvPullRequest.new do
9696
if NaturalNumberString
97-
.natural_number_string? ENV['PULL_REQUEST_ID']
97+
.positive_integer_string? ENV['PULL_REQUEST_ID']
9898
ENV['PULL_REQUEST_ID'].to_i
9999
end
100100
end.pull_request? == true
@@ -104,7 +104,7 @@ def self.shutdown
104104
assert do
105105
EnvPullRequest.new do
106106
if NaturalNumberString
107-
.natural_number_string? ENV['PULL_REQUEST_ID']
107+
.positive_integer_string? ENV['PULL_REQUEST_ID']
108108
ENV['PULL_REQUEST_ID'].to_i
109109
end
110110
end.pull_request_id == pull_id
@@ -130,7 +130,7 @@ def self.shutdown
130130
assert do
131131
EnvPullRequest.new do
132132
if NaturalNumberString
133-
.natural_number_string? ENV['PULL_REQUEST_ID']
133+
.positive_integer_string? ENV['PULL_REQUEST_ID']
134134
ENV['PULL_REQUEST_ID'].to_i
135135
end
136136
end.pull_request? == true
@@ -140,7 +140,7 @@ def self.shutdown
140140
assert do
141141
EnvPullRequest.new do
142142
if NaturalNumberString
143-
.natural_number_string? ENV['PULL_REQUEST_ID']
143+
.positive_integer_string? ENV['PULL_REQUEST_ID']
144144
ENV['PULL_REQUEST_ID'].to_i
145145
end
146146
end.pull_request_id == pull_id

0 commit comments

Comments
 (0)