Skip to content

Conversation

@mefellows
Copy link
Contributor

PACT-4283

@mefellows mefellows requested a review from YOU54F July 1, 2025 08:01
@netlify
Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for docs-pactflow-preview ready!

Name Link
🔨 Latest commit fa228f8
🔍 Latest deploy log https://app.netlify.com/projects/docs-pactflow-preview/deploys/68670830831fc200080c8e25
😎 Deploy Preview https://deploy-preview-391--docs-pactflow-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@JP-Ellis JP-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions

@mefellows mefellows requested a review from kopernic-pl July 2, 2025 00:25
@mefellows mefellows force-pushed the docs/PACT-4283-add-rbac-docs branch from e516936 to 4379bc1 Compare July 2, 2025 03:07
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, great first pass and love the simple conceptual example.

@mefellows mefellows requested review from MateuszKupczakSB and removed request for kopernic-pl July 3, 2025 02:10
Copy link
Contributor

@MateuszKupczakSB MateuszKupczakSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to update, and it will be fine.

@mefellows mefellows force-pushed the docs/PACT-4283-add-rbac-docs branch from 4379bc1 to 3e59a14 Compare July 3, 2025 22:45
@mefellows mefellows force-pushed the docs/PACT-4283-add-rbac-docs branch from 3e59a14 to fa228f8 Compare July 3, 2025 22:46
@mefellows
Copy link
Contributor Author

Thanks @MateuszKupczakSB - made your updates (and merging!).

@mefellows mefellows merged commit 2d62c1f into master Jul 3, 2025
1 check was pending
@mefellows mefellows deleted the docs/PACT-4283-add-rbac-docs branch July 3, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants