[WIP] Carousal component #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monty2610 any progress here? |
|
Hi @vinodloha I have already updated the test cases. Please review. |
vinodloha
reviewed
Dec 7, 2018
| return null; | ||
| } | ||
| return ( | ||
| <section className={className}> |
There was a problem hiding this comment.
Don't think section would be right wrapper tag for it.
vinodloha
reviewed
Dec 19, 2018
| )} | ||
| </div> | ||
| {showDots && ( | ||
| <Dots |
There was a problem hiding this comment.
How can someone configure images, instead of dots as indicators? There should be a way to do that, The dots could be default behaviour
| sectionFn: () => ( | ||
| <div style={{ width: '480px', margin: '0 auto' }}> | ||
| <Carousal {...defaultConfig}> | ||
| <Image src="https://via.placeholder.com/480.png/FF0000/fff" /> |
There was a problem hiding this comment.
How is responsive behaviour is going to work? For example: Single slide on mobile and multiple slide to be combined of needed on large viewport.
…components into feature/carousal
back merging the develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.