Laxman feat #10
Open
Laxman feat #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
laxman-aqw
commented
Nov 17, 2025
laxman-aqw
commented
- Merged all the branches.
laxman-aqw
requested review from
Aayush1011,
Nijarshrestha,
Pratikpr8 and
SumitShrestha11
Aayush1011
reviewed
Nov 19, 2025
Comment on lines
+14
to
+16
| <label className={styles["input-field__label"]}> | ||
| {label.charAt(0).toUpperCase() + label.slice(1)} | ||
| </label> |
There was a problem hiding this comment.
you can use css text-transform: capitalize here instead of capitalizing the first letter through js
Aayush1011
reviewed
Nov 19, 2025
| @@ -0,0 +1,40 @@ | |||
| .increment, .decrement{ | |||
| background-color: rgb(32, 175, 32); | |||
There was a problem hiding this comment.
Just a suggestion but it might be a better idea to use only rgb color or hex code everywhere as I noticed you're using both
Aayush1011
reviewed
Nov 19, 2025
Comment on lines
+32
to
+37
| .input-field__value { | ||
| margin-top: 4px; | ||
| font-size: 12px; | ||
| color: #555; | ||
| font-style: italic; | ||
| } |
There was a problem hiding this comment.
this class and its associated properties appear to be unused
Aayush1011
reviewed
Nov 19, 2025
Comment on lines
+12
to
+14
| <li key={index} className={styles["item-list__item"]} onClick={() => setSelectedItem(item)}> | ||
| {item} | ||
| </li> |
There was a problem hiding this comment.
I don't think the onClick here has any effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.