Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change license #5

Closed
facontidavide opened this issue Jun 8, 2020 · 3 comments
Closed

Change license #5

facontidavide opened this issue Jun 8, 2020 · 3 comments

Comments

@facontidavide
Copy link

facontidavide commented Jun 8, 2020 •
edited
Loading

Hi,

the LGPL license is very limiting for a library like pal_statistics.

Since this library is supposed to be used in pretty much all the nodes of the system that the user wants to monitor, we are reasonably concerned by the viral nature of this license.

Would you consider changing it to MIT or BSD?
@v-lopez
Copy link
Contributor

v-lopez commented Jun 8, 2020

Yeah, I think that shouldn't be an issue.

I'll get back on this in a few days.

@veimox
Copy link

veimox commented Jun 16, 2020 •
edited
Loading

@v-lopez Thanks for that! You forgot to remove the GPL license from the header files 😄

@v-lopez
Copy link
Contributor

v-lopez commented Jun 17, 2020

Thanks @veimox, you are right.

I have fixed it, tonight it will be synchronized.

pal-admin pushed a commit that referenced this issue Jun 18, 2020
Update license on headers
785c735 
refs #5
pal-admin pushed a commit that referenced this issue Dec 13, 2023
@atzaros
Make gtest failure messages more informative in aync tests
e671e6b 
For instance from:
/home/user/exchange/roses/alum/pal_statistics_ws/src/pal_statistics/pal_statistics/test/gtest_pal_statistics.cpp:580: Failure
Value of: waitFor( std::bind( stats_published_for, "macro_var1", "clp-failure", "macro_var1_bk", "macro_var2", "&var2_"))
  Actual: false
Expected: true

to:
/home/user/exchange/roses/alum/pal_statistics_ws/src/pal_statistics/pal_statistics/test/gtest_pal_statistics.cpp:673: Failure
After 300 msValue of: get_variables
Expected: has 9 elements and there exists some permutation of elements such that:
 - element #0 is equal to "macro_var1", and
 - element #1 is equal to "clp-failure", and
 - element #2 is equal to "macro_var1_bk", and
 - element #3 is equal to "macro_var2", and
 - element #4 is equal to "&var2_", and
 - element #5 is equal to "topic_stats.pal_statistics_node_test/pal_statistics.publish_async_attempts", and
 - element #6 is equal to "topic_stats.pal_statistics_node_test/pal_statistics.publish_async_failures", and
 - element #7 is equal to "topic_stats.pal_statistics_node_test/pal_statistics.publish_buffer_full_errors", and
 - element #8 is equal to "topic_stats.pal_statistics_node_test/pal_statistics.last_async_pub_duration"
  Actual: { "topic_stats.pal_statistics_node_test/pal_statistics.publish_async_attempts", "topic_stats.pal_statistics_node_test/pal_statistics.publish_async_failures", "topic_stats.pal_statistics_node_test/al_statistics.publish_buffer_full_errors", "topic_stats.pal_statistics_node_test/pal_statistics.last_async_pub_duration", "macro_var1", "macro_var1_bk", "macro_var2", "&var2_" }, which has 8 elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@facontidavide @v-lopez @veimox