Skip to content

[fix] Re-add SerializableError backcompat fields as write-only #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 23, 2018
Merged

[fix] Re-add SerializableError backcompat fields as write-only #115

merged 9 commits into from
Aug 23, 2018

Conversation

@dansanduleac
Copy link
Contributor

@dansanduleac dansanduleac commented Aug 23, 2018 •
edited
Loading

This reverts the removals that occurred here: https://github.com/palantir/http-remoting-api/pull/100/files#diff-1604ffe60cf0f42a265fa29f94cbf660
And re-adds the fallback onto the old fields exceptionClass and message but in a cleaner way:

  • no more weird exception message because of the cycles between exceptionClass <-> errorCode and message <-> errorName
  • explicit, SafeLoggable errors when the required field as well as its fallback are both missing
  • deprecated fallback fields no longer participate in equals, hashCode, toString; they are only used as a fallback if the original field wasn't set, otherwise they are essentially dropped

@dansanduleac dansanduleac requested a review from a team as a code owner August 23, 2018 16:23
@dansanduleac dansanduleac requested a review from iamdanfox August 23, 2018 16:36
iamdanfox
iamdanfox reviewed Aug 23, 2018
View reviewed changes
errors/src/main/java/com/palantir/conjure/java/api/errors/SerializableError.java Outdated
@JsonProperty(value = "exceptionClass", access = JsonProperty.Access.WRITE_ONLY)
@Value.Auxiliary
@SuppressWarnings("checkstyle:designforextension")
// TODO(rfink): Remove once all error producers have switched to errorCode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think is really ever going to happen - possibly worth deleting entirely?

@dansanduleac dansanduleac merged commit ff297df into conjure Aug 23, 2018
@dansanduleac dansanduleac deleted the ds/backcompat-serializable-error branch August 23, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dansanduleac @iamdanfox