improvement: move errorInstanceId from exception message into exception args #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Aug 27, 2020
errors/src/main/java/com/palantir/conjure/java/api/errors/RemoteException.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 27, 2020 12:11
…jure-java-runtime-api into fo/remote-exception-message
|
Released 2.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We were attempting to perform some internal analysis on unique stacktraces but were running into issues since we grouped stacktraces textually and the error instance id appeared as part of the message of each remote exception
After this PR
==COMMIT_MSG==
move
RemoteExceptions errorInstanceId from exception message into exception args==COMMIT_MSG==
Possible downsides?
It will be harder to debug issue if logging is not set up (i.e. args are logged) correctly since the message will not contain the error id