ServiceException no longer throws NPE when null args are provided #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
reviewed
Sep 10, 2020
| } else { | ||
| builder.append(", "); | ||
| } | ||
| builder.append(arg.getName()).append("=").append(arg.getValue()); |
There was a problem hiding this comment.
Do we want to keep the information that an arg was null in the message? E.g. rendering something like {arg1=null}? That way you could see that something went wrong passing through the args when inspecting the logs.
There was a problem hiding this comment.
I don't think that tells us anything, and we would have to use a funky argument name to prevent duplication with user-provided arg names.
fawind
approved these changes
Sep 10, 2020
|
🤖🍿 |
bulldozer-bot
bot
deleted the
ckozak/serviceexception_resilient_to_null_args
branch
|
Released 2.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The render method threw a NPE when an argument value was null. This exception destroys our ability to capture the root cause -- we must either set the original as a cause/suppressed-cause or provide as much data as possible.
It's clearly not ideal to have null arg values, however it's even worse if we're unable to diagnose the original problem based on logging, so we mustn't be opinionated here.
After this PR
==COMMIT_MSG==
ServiceException no longer throws NPE when null args are provided
==COMMIT_MSG==
See palantir/safe-logging#492
Possible downsides?
none.