Java files always end with a new line #1433
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
| // Ensure the file ends with a newline | ||
| builder.forcedBreak(); |
There was a problem hiding this comment.
Can we write a test for this?
There was a problem hiding this comment.
Also perhaps the multiple lines at the end of the file case
|
Adding |
| case "--character-range": | ||
| case "-character-range": | ||
| parseRangeSet(optionsBuilder.characterRangesBuilder(), getValue(flag, it, value)); | ||
| parseCharacterRanges(optionsBuilder.characterRangesBuilder(), getValue(flag, it, value)); |
There was a problem hiding this comment.
Bug from the beginning of pjf. parseRangeSet expects a 1-indexed range, but we have a 0-indexed range (see RnageUtils class).
This would mean that Intellij only (./gradlew spotless would work correclty as it doesn't use the same getReplacements workflow) would not reformat the full file eg. after formatting the "format.input" file, we'd get a truncated version of the formatted output:
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
intentionally removing the last line to make sure we are getting the error seen in: https://github.com/palantir/palantir-java-format/pull/1433/files#r2429564482
|
Released 2.79.0 |
Before this PR
Checkstyle requires Java files to end with a new line see here.
After this PR
We are now enforcing this through the formatter directly.
Fixed a bug where Bootstrapping/NativeImageFormatter were incorrectly reading the input range as a 1-index vs 0-index.
==COMMIT_MSG==
Java files always end with a new line
==COMMIT_MSG==
Possible downsides?