Skip to content

Fix JMH benchmarking #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2025
Merged

Fix JMH benchmarking #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc27ab2
Fix JMH benchmarking
schlosna Apr 15, 2025
25ec0ec
Add generated changelog entries
svc-changelog Apr 15, 2025
1a9a957
writeLocks
schlosna Apr 15, 2025
e1c2a9d
Adjust benchmark config
schlosna Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ buildscript {
classpath 'com.palantir.gradle.gitversion:gradle-git-version:4.0.0'
classpath 'com.palantir.gradle.idea-configuration:gradle-idea-configuration:0.5.0'
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.36.0'
classpath 'me.champeau.gradle:jmh-gradle-plugin:0.5.3'
classpath 'me.champeau.jmh:jmh-gradle-plugin:0.7.3'
}
}

Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1412.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: '`./gradlew jmh` works'
links:
- https://github.com/palantir/tracing-java/pull/1412
11 changes: 8 additions & 3 deletions tracing-benchmarks/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,21 @@
* (c) Copyright 2018 Palantir Technologies Inc. All rights reserved.
*/

apply plugin: 'me.champeau.gradle.jmh'
apply plugin: 'me.champeau.jmh'

jmh {
// Use profilers to collect additional data. Supported profilers:
// [cl, comp, gc, stack, perf, perfnorm, perfasm, xperf, xperfasm, hs_cl, hs_comp, hs_gc, hs_rt, hs_thr]
profilers = ['gc']
// profilers = ['gc']
warmupIterations = 10
warmup = '500ms'
iterations = 10
timeOnIteration = '750ms'
threads = 4
}

tasks.jmhCompileGeneratedClasses {
options.annotationProcessorPath = configurations.errorprone
options.annotationProcessorPath = configurations.jmhAnnotationProcessor
options.errorprone.enabled = false
}

Expand Down
4 changes: 2 additions & 2 deletions versions.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ org.jboss.xnio:xnio-api:3.8.7.Final (2 constraints: 771a3146)
org.jboss.xnio:xnio-nio:3.8.7.Final (1 constraints: c80dcb30)
org.jetbrains:annotations:26.0.2 (2 constraints: 0221656e)
org.jspecify:jspecify:1.0.0 (3 constraints: 9f1f57e1)
org.openjdk.jmh:jmh-core:1.37 (5 constraints: 5047ece4)
org.openjdk.jmh:jmh-core:1.37 (5 constraints: 52476be6)
org.openjdk.jmh:jmh-generator-annprocess:1.37 (1 constraints: df04fc30)
org.slf4j:slf4j-api:2.0.17 (8 constraints: 2875c85f)
org.wildfly.client:wildfly-client-config:1.0.1.Final (1 constraints: 940c6308)
Expand Down Expand Up @@ -111,7 +111,7 @@ org.mockito:mockito-core:5.18.0 (2 constraints: 38148e87)
org.mockito:mockito-junit-jupiter:5.18.0 (1 constraints: 4005593b)
org.objenesis:objenesis:3.3 (1 constraints: b20a14bd)
org.openjdk.jmh:jmh-generator-asm:1.37 (1 constraints: 2c107598)
org.openjdk.jmh:jmh-generator-bytecode:1.37 (1 constraints: dc04f830)
org.openjdk.jmh:jmh-generator-bytecode:1.37 (1 constraints: de04fb30)
org.openjdk.jmh:jmh-generator-reflection:1.37 (2 constraints: 491e3064)
org.opentest4j:opentest4j:1.3.0 (2 constraints: cf209249)
org.ow2.asm:asm:9.0 (2 constraints: 641531ca)
Expand Down