Restore trace state back to cleared when wrapWithNewTrace is called with no trace state #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Proposed fix for #51 |
carterkozak
reviewed
Jan 10, 2019
| return Preconditions.checkNotNull(currentTrace.get(), "There is no root span").getTraceId(); | ||
| } | ||
|
|
||
| /** Clears the current trace id and returns (a copy of) it if present */ |
Contributor
There was a problem hiding this comment.
I don't think this makes a copy
carterkozak
reviewed
Jan 10, 2019
dsd987
force-pushed
the
dd/wrapWithNewTraceRestore
branch
2 times, most recently
from
fda93bc to
72ba144
Compare
carterkozak
reviewed
Jan 10, 2019
carterkozak
reviewed
Jan 10, 2019
| } | ||
|
|
||
| /** Clears the current trace id and returns it if present. */ | ||
| static Optional<Trace> getAndClearTraceIfPresent() { |
Contributor
There was a problem hiding this comment.
I'd like if this was public, but we can look into that in a separate PR!
…ith no trace state.
dsd987
force-pushed
the
dd/wrapWithNewTraceRestore
branch
from
72ba144 to
63b6ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
Tracers::wrapWithNewTracewas called with no trace state, the trace state would incorrectly be restored to a new trace rather than the cleared state. Now, the trace state will be appropriately returned to the cleared state.