Skip to content

Decrease default sample rate from 1% to .05% to match internal tools #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Decrease default sample rate from 1% to .05% to match internal tools #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40a2593
Decrease default sample rate from 1% to .05% to match internal tools
carterkozak Mar 29, 2021
265f32d
Add generated changelog entries
carterkozak Mar 29, 2021
fd22ff0
Update tracing/src/main/java/com/palantir/tracing/Tracer.java
carterkozak Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-698.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Decrease default sample rate from 1% to .05% to match internal tools
links:
- https://github.com/palantir/tracing-java/pull/698
2 changes: 1 addition & 1 deletion tracing/src/main/java/com/palantir/tracing/Tracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private Tracer() {}
private static volatile Consumer<Span> compositeObserver = _span -> {};

// Thread-safe since stateless
private static volatile TraceSampler sampler = RandomSampler.create(0.01f);
private static volatile TraceSampler sampler = RandomSampler.create(0.0005f);

/** Creates a new trace, but does not set it as the current trace. */
private static Trace createTrace(Observability observability, String traceId, Optional<String> requestId) {
Expand Down