Allow conjure-undertow to leverage the DetachedSpan.attach() mechanism
#773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove a largely redundant tracing span and flatten our graphs very slightly. Note that the sampled span warn-if-completed logging has been removed. I think adding it originally was a mistake given the probabilistic nature. There are many scenarios in which a server exchange may end prior to code execution (for example when clients disconnect) where we would expect to see these warnings. This leads us to a potential downside: When clients disconnect before the server finishes processing blocking work, the spans may provide somewhat less information. This is an edge case, and I don't believe it's worth the additional spans, but is worth describing here.
Generate changelog in
|
jkozlowski
approved these changes
Sep 9, 2021
bulldozer-bot
bot
deleted the
ckozak/allow_conjure_undertow_to_leverage_attach
branch
Collaborator
|
Released 6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove a largely redundant tracing span and flatten
our graphs very slightly.
Note that the sampled span warn-if-completed logging has been
removed. I think adding it originally was a mistake given
the probabilistic nature. There are many scenarios in which
a server exchange may end prior to code execution (for example
when clients disconnect) where we would expect to see these
warnings.
==COMMIT_MSG==
Allow conjure-undertow to leverage the
DetachedSpan.attach()mechanism without creating spans for blocking work==COMMIT_MSG==
Possible downsides?
When clients disconnect
before the server finishes processing blocking work, the spans
may provide somewhat less information. This is an edge case,
and I don't believe it's worth the additional spans, but is worth
describing here.