Skip to content

Optimize pruning and fix entry counting bug in FileSystemCache#52

Merged
northernSage merged 4 commits intopallets-eco:mainfrom
northernSage:optimize-prune-and-dir-listing
Jul 22, 2021
Merged

Optimize pruning and fix entry counting bug in FileSystemCache#52
northernSage merged 4 commits intopallets-eco:mainfrom
northernSage:optimize-prune-and-dir-listing

Conversation

@northernSage
Copy link
Copy Markdown
Member

@northernSage northernSage commented Jul 11, 2021 •
edited
Loading

  • Optimize pruning performance by avoiding unnecessary iterations over cache entries with generators
  • Fix bug where the meta file used for counting cache entries would be deleted. This was silently breaking FileSystemCache._prune since FileSystemCache would not keep track of cache entries anymore.
  • add change log
  • update test

@northernSage northernSage added bug Something isn't working enhancement New feature or request labels Jul 11, 2021
@northernSage northernSage self-assigned this Jul 11, 2021
@northernSage northernSage requested a review from davidism July 11, 2021 20:31
@northernSage northernSage mentioned this pull request Jul 15, 2021
Closed
@northernSage northernSage merged commit 79221ea into pallets-eco:main Jul 22, 2021
@northernSage northernSage deleted the optimize-prune-and-dir-listing branch July 22, 2021 00:06
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidism davidism Awaiting requested review from davidism

Assignees

@northernSage northernSage

Labels

bug Something isn't working enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@northernSage