feat(arithmetic): #1347 #1378 ➗ truediv

[cmp0xff]

• Addresses Index arithmetic overloads show wrong types #1347 and Create tests for arithmetic for TimedeltaIndex and DatetimeIndex #1378
• Tests added

[Dr-Irv]

Biggest issue here is the use of Index[Timedelta], which I would prefer if we could avoid in the stubs, even though it can be created via some non-standard usage.

[cmp0xff]

Biggest issue here is the use of Index[Timedelta], which I would prefer if we could avoid in the stubs, even though it can be created via some non-standard usage.

I would say that a community decision can clarify the situation, if you would help 🙂

[Dr-Irv]

Biggest issue here is the use of Index[Timedelta], which I would prefer if we could avoid in the stubs, even though it can be created via some non-standard usage.

I would say that a community decision can clarify the situation, if you would help 🙂

That might take a while. But in pandas-stubs, I think we can just not have overloads that create Index[Timedelta] nor overloads that assume self: Index[Timedelta] or other is Index[Timedelta] in the stubs. So we don't support it, which would cause code such as pd.Index([1]) * [pd.Timedelta(seconds=5)] to not pass the type checker (and we can put that in our tests).

If people complain that the stubs don't work because they are creating code that is essentially a Index[Timedelta], (really seen as an Index with object dtype), then we tell them to do pd.TimedeltaIndex(foo) if foo is an Index with timedelta objects in it.

[Dr-Irv]

Everything looks fine. The only thing I'm not sure about - and this might just be a Github issue - is that the directory tests/indexes/arithmetic/timedelta is not showing as being removed from the repo. I see that it is not present in your branch in your repo.

Can you tell if you did an explicit commit that has git rm tests/indexes/arithmetic/timedelta ?

If you can't tell, I can approve and merge, and if it is still there, then do a separate PR to fix that.

[cmp0xff]

I cannot delete it any further.

> git rm .\tests\indexes\arithmetic\timedelta
fatal: pathspec '.\tests\indexes\arithmetic\timedelta' did not match any files

I think git does not keep empty folders.

[Dr-Irv]

thanks @cmp0xff

[Dr-Irv]

I cannot delete it any further.

> git rm .\tests\indexes\arithmetic\timedelta
fatal: pathspec '.\tests\indexes\arithmetic\timedelta' did not match any files

I think git does not keep empty folders.

OK. I approved and merged and the folder is gone. But the review process indicated it was still there. Hence the confusion