feat: use ruff to drive typing of submodules #1448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
force-pushed
the
feature/classify-ann
branch
from
4d100c0 to
65f1503
Compare
|
There is a small conflict, please resolve when you have time and I will merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the
ANNrules of ruff to drive typing of submodules, as can be seen in the changes inpyproject.tomlin this PR.When a submodule is completely typed, the corresponding ruff ignores of ANN rules can be removed.
This PR addresses #1442, #1443, #1444 and #1446 and adds a few typing in other places (or removes the functionality if it is private).