- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 152
 
Type CategoricalIndex #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Type CategoricalIndex #1459
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      6518ad3
              
                wip
              
              
                MarcoGorelli cb0709f
              
                bit more
              
              
                MarcoGorelli 6dc0ea9
              
                testing
              
              
                MarcoGorelli 0015e53
              
                more tests
              
              
                MarcoGorelli 5365bfc
              
                fixup `insert`
              
              
                MarcoGorelli 63d54f2
              
                include `np.integer`, as per upstream
              
              
                MarcoGorelli 651cf09
              
                type `categories` too
              
              
                MarcoGorelli 97b4261
              
                update pyproject.toml
              
              
                MarcoGorelli File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| from __future__ import annotations | ||
| 
     | 
||
| import numpy as np | ||
| import pandas as pd | ||
| from typing_extensions import ( | ||
| assert_type, | ||
| ) | ||
| 
     | 
||
| from tests import ( | ||
| check, | ||
| np_1darray, | ||
| ) | ||
| 
     | 
||
| 
     | 
||
| def test_categoricalindex_unique() -> None: | ||
| ci = pd.CategoricalIndex(["a", "b"]) | ||
| check( | ||
| assert_type(ci.unique(), "pd.CategoricalIndex[str]"), | ||
| pd.CategoricalIndex, | ||
| ) | ||
| 
     | 
||
| 
     | 
||
| def test_categoricalindex_reindex() -> None: | ||
| ci = pd.CategoricalIndex(["a", "b"]) | ||
| check( | ||
| assert_type(ci.reindex([0, 1]), tuple[pd.Index, np_1darray[np.intp] | None]), | ||
| tuple, | ||
| ) | ||
| 
     | 
||
| 
     | 
||
| def test_categoricalindex_delete() -> None: | ||
| ci = pd.CategoricalIndex(["a", "b"]) | ||
| check(assert_type(ci.delete(0), "pd.CategoricalIndex[str]"), pd.CategoricalIndex) | ||
| check( | ||
| assert_type(ci.delete([0, 1]), "pd.CategoricalIndex[str]"), pd.CategoricalIndex | ||
| ) | ||
| 
     | 
||
| 
     | 
||
| def test_categoricalindex_insert() -> None: | ||
| ci = pd.CategoricalIndex(["a", "b"]) | ||
| check(assert_type(ci.insert(0, "c"), pd.Index), pd.Index) | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs just say "iterable"
https://github.com/pandas-dev/pandas/blob/b015a3bfb49ec98eec2635d93ce3ebb8d5dad0c2/pandas/core/indexes/base.py#L4116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for a non-Sequence generator. Fun fact:
Maybe for another PR.