Skip to content

fix: 🌃 nightly #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

fix: 🌃 nightly #1487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df63a86
fix nightly
cmp0xff Nov 13, 2025
39a3d39
fix pytest
cmp0xff Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/series/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,7 +2222,7 @@ def test_pandera_generic() -> None:

class MySeries(pd.Series, Generic[T]):
def __new__(cls, *args: Any, **kwargs: Any) -> Self:
return object.__new__(cls)
return super().__new__(cls) # type: ignore[return-value] # pyright: ignore[reportReturnType]
Copy link
Collaborator

@Dr-Irv Dr-Irv Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't want # type: ignore in the test files, except in the following cases:

  1. the type checkers disagree - one is OK, but the other flags it, so we have to ignore for one of the checkers
  2. When we are doing TYPE_CHECKING_INVALID_USAGE

I think the following will make this work:

        def __new__(cls, *args: Any, **kwargs: Any) -> MySeries[T]:
            return cast(MySeries[T], super().__new__(cls))

In this case, you have to do the cast because of how __new() works.

@cmp0xff or @loicdiridollou can you try this and get it to work?

Copy link
Contributor Author

@cmp0xff cmp0xff Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this comment. @loicdiridollou has created #1489.

My understanding used to be that ignores are not allowed in tests, and these new ignores are not in tests themselves.


def func() -> MySeries[float]:
return MySeries[float]([1, 2, 3])
Expand Down