STYLE: fix pylint consider-iterating-dictionary warnings (#49305)

Author: Moisan

pandas/core/groupby/generic.py

@@ -332,7 +332,7 @@ def _aggregate_multiple_funcs(self, arg) -> DataFrame:
             from pandas import concat
 
             res_df = concat(
-                results.values(), axis=1, keys=[key.label for key in results.keys()]
+                results.values(), axis=1, keys=[key.label for key in results]
             )
             return res_df
 

pandas/io/clipboard/__init__.py

@@ -608,7 +608,7 @@ def set_clipboard(clipboard):
     }
 
     if clipboard not in clipboard_types:
-        allowed_clipboard_types = [repr(_) for _ in clipboard_types.keys()]
+        allowed_clipboard_types = [repr(_) for _ in clipboard_types]
         raise ValueError(
             f"Argument must be one of {', '.join(allowed_clipboard_types)}"
         )

pandas/io/formats/style_render.py

@@ -2284,7 +2284,7 @@ def color(value, user_arg, command, comm_arg):
         if isinstance(value, str) and "--latex" in value:
             # return the style without conversion but drop '--latex'
             latex_styles.append((attribute, value.replace("--latex", "")))
-        if attribute in CONVERTED_ATTRIBUTES.keys():
+        if attribute in CONVERTED_ATTRIBUTES:
             arg = ""
             for x in ["--wrap", "--nowrap", "--lwrap", "--dwrap", "--rwrap"]:
                 if x in str(value):

pandas/tests/reshape/test_pivot.py

@@ -1699,7 +1699,7 @@ def test_pivot_table_with_iterator_values(self, data):
         )
         tm.assert_frame_equal(pivot_values_keys, pivot_values_list)
 
-        agg_values_gen = (value for value in aggs.keys())
+        agg_values_gen = (value for value in aggs)
         pivot_values_gen = pivot_table(
             data, index=["A"], values=agg_values_gen, aggfunc=aggs
         )

pandas/tests/series/test_api.py

@@ -180,7 +180,7 @@ def test_unknown_attribute(self):
         # GH#9680
         tdi = pd.timedelta_range(start=0, periods=10, freq="1s")
         ser = Series(np.random.normal(size=10), index=tdi)
-        assert "foo" not in ser.__dict__.keys()
+        assert "foo" not in ser.__dict__
         msg = "'Series' object has no attribute 'foo'"
         with pytest.raises(AttributeError, match=msg):
             ser.foo

pyproject.toml

@@ -79,7 +79,6 @@ disable = [
   "used-before-assignment",
 
  # pylint type "C": convention, for programming standard violation
-  "consider-iterating-dictionary",
   "consider-using-f-string",
   "disallowed-name",
   "import-outside-toplevel",