Skip to content

Fix overflow error in cartesian_product #15265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix overflow error in cartesian_product #15265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b196878
Fix overflow error in cartesian_product
david-hoffman Jan 30, 2017
7aeee85
Added tests for large numbers
david-hoffman Jan 30, 2017
47a6c6c
Update test so that it will actually run on "normal" machine
david-hoffman Jan 30, 2017
d54583e
Remove `test_large_input` because it's too big
david-hoffman Jan 30, 2017
c9c8d5e
Update v0.19.2.txt
david-hoffman Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.19.2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,4 @@ Bug Fixes
- Explicit check in ``to_stata`` and ``StataWriter`` for out-of-range values when writing doubles (:issue:`14618`)
- Bug in ``.plot(kind='kde')`` which did not drop missing values to generate the KDE Plot, instead generating an empty plot. (:issue:`14821`)
- Bug in ``unstack()`` if called with a list of column(s) as an argument, regardless of the dtypes of all columns, they get coerced to ``object`` (:issue:`11847`)
- Fix bug (:issue:`15265`) in ``cartesian_product`` in ``pandas.tools.util`` that caused an uncaught overflow error when using large arguments.
2 changes: 1 addition & 1 deletion pandas/tools/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def cartesian_product(X):
if len(X) == 0:
return []

lenX = np.fromiter((len(x) for x in X), dtype=int)
lenX = np.fromiter((len(x) for x in X), dtype=np.intp)
cumprodX = np.cumproduct(lenX)

a = np.roll(cumprodX, 1)
Expand Down