Skip to content

Index tests in the wrong places #18074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2017
Merged

Index tests in the wrong places #18074

merged 6 commits into from
Nov 2, 2017

Conversation

@jbrockmendel
Copy link
Member

No description provided.

jreback
jreback requested changes Nov 2, 2017
View reviewed changes
pandas/tests/indexes/datetimes/test_astype.py Outdated
tm.assert_index_equal(result, expected)

def test_astype_object(self):
# NumPy 1.6.1 weak ns support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this comment FYI

pandas/tests/indexes/datetimes/test_setops.py Outdated
result = i1.union(i2)
expected = Int64Index(np.arange(0, 30, 2))
tm.assert_index_equal(result, expected)
for tz in self.tz:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use loops, parametrize

pandas/tests/indexes/datetimes/test_setops.py Outdated
result = index_1 & index_2
assert len(result) == 0

def test_difference(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite labels Nov 2, 2017
@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #18074 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18074      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50120    50120              
==========================================
- Hits        45737    45728       -9     
- Misses       4383     4392       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fa4bd...111316e. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 2, 2017 •
edited
Loading

Codecov Report

Merging #18074 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18074      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50120    50120              
==========================================
+ Hits        45737    45740       +3     
+ Misses       4383     4380       -3
Flag Coverage Δ
#multiple 89.07% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd3bd7...846032f. Read the comment docs.

@jbrockmendel
Copy link
Member Author

Just pushed with parameterizing moved tests. There are a bunch of tests elsewhere that use for loops over self.tz. I'll get to them at some point in this sequence of PRs.

@jreback jreback added this to the 0.22.0 milestone Nov 2, 2017
@jreback
Copy link
Contributor

jreback commented Nov 2, 2017

thanks!

@jreback jreback merged commit 804fb99 into pandas-dev:master Nov 2, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Nov 3, 2017
@jbrockmendel @kchomski
Index tests in the wrong places (pandas-dev#18074)
8c49653
1kastner pushed a commit to 1kastner/pandas that referenced this pull request Nov 5, 2017
@jbrockmendel @1kastner
Index tests in the wrong places (pandas-dev#18074)
ef9a06c
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jbrockmendel @No-Stream
Index tests in the wrong places (pandas-dev#18074)
4a14a45
@jbrockmendel jbrockmendel deleted the index_tests branch December 8, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback