Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive check for argument errors keyword in to_numeric #26466

Merged
merged 3 commits into from May 20, 2019

Conversation

@sumanau7
Copy link
Contributor

commented May 20, 2019

  • closes #26394
  • tests passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • Added defensive check for argument errors in func to_numeric
@gfyoung

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@sumanau7 : Thanks for the PR! Can you add a test and a whatsnew entry into v0.25.0.rst?

@sumanau7

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

@gfyoung sure i will complete it within next 24 hours and update.

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #26466 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26466      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50763    50765       +2     
==========================================
- Hits        46575    46574       -1     
- Misses       4188     4191       +3
Flag Coverage Δ
#multiple 90.25% <100%> (ø) ⬆️
#single 41.69% <0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/numeric.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5498...4de3f1a. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #26466 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26466      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50763    50765       +2     
==========================================
- Hits        46575    46573       -2     
- Misses       4188     4192       +4
Flag Coverage Δ
#multiple 90.25% <50%> (-0.01%) ⬇️
#single 41.72% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/numeric.py 98.55% <50%> (-1.45%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5498...5bdd8a4. Read the comment docs.

Sumanau Sareen added some commits May 20, 2019

@sumanau7

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

@gfyoung Is it good now ?

@jorisvandenbossche jorisvandenbossche changed the title Add defensive check for argument `errors` in func `to_numeric`. Add defensive check for argument errors keyword in to_numeric May 20, 2019

@jorisvandenbossche jorisvandenbossche merged commit 1add02c into pandas-dev:master May 20, 2019

11 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190520.17 succeeded
Details
pandas-dev.pandas (Checks_and_doc) Checks_and_doc succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@sumanau7 thanks a lot!

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone May 20, 2019

gfyoung added a commit that referenced this pull request May 20, 2019

DOC: whatsnew fixes
Follow-up to gh-26466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.