Skip to content

Conversation

grigoriosgiann
Copy link
Contributor

Use Optional to signal that the value may be either an Index or None.

@grigoriosgiann grigoriosgiann force-pushed the fix-test-numeric branch 3 times, most recently from f089977 to 0c9d4b5 Compare October 14, 2019 16:45
@datapythonista datapythonista added the Typing type annotations, mypy/pyright type checking label Oct 14, 2019
@datapythonista
Copy link
Member

You'll have to rerun the CI.

Use Optional to signal that the value may be either an `Index` or `None`.
@grigoriosgiann
Copy link
Contributor Author

grigoriosgiann commented Oct 14, 2019

Tests passed, rebasing on top of master squashing my fixup...

P.S. Thanks for the label, completely forgot about it! 😃

@WillAyd WillAyd added this to the 1.0 milestone Oct 14, 2019
@simonjayhawkins
Copy link
Member

@grigoriosgiann Thanks for the PR. This partly overlaps with #28961. will revisit this once #28961 merged.

@jjlkant jjlkant mentioned this pull request Oct 15, 2019
38 tasks
@simonjayhawkins
Copy link
Member

overlaps with #28961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants