Skip to content

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Nov 6, 2019

We don't want this long-term. But there's no easy way
to skip this for numpydev, since it errors in setup.

xref #29432 (keep open till numpydev is fixed)

We don't want this long-term. But there's no easy way
to skip this for numpydev, since it errors in setup.
@jbrockmendel
Copy link
Member

pending green, lgtm

@TomAugspurger
Copy link
Contributor Author

It's failing in many places now. I suspect numpy will revert this change, but I'm tracking that in numpy/numpy#14800.

For now, we'll ignore failures on numpydev.

@gfyoung gfyoung added the Dependencies Required and optional dependencies label Nov 6, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @TomAugspurger !

@jreback jreback added this to the 1.0 milestone Nov 6, 2019
@jbrockmendel
Copy link
Member

trailing whitespace

@jreback jreback merged commit b4adb71 into pandas-dev:master Nov 6, 2019
@TomAugspurger TomAugspurger deleted the numpydev-fixup branch November 6, 2019 21:21
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Nov 11, 2019
jbrockmendel pushed a commit to TomAugspurger/pandas that referenced this pull request Nov 12, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Dependencies Required and optional dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants