TYP: some types for pandas/_config/config.py #29897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
small comments, non-blockers, LGTM |
Member
|
LGTM |
WillAyd
approved these changes
Nov 29, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
lgtm. optional comment to maybe address or merge if you disagree
| raise ValueError("{k} is not a valid identifier".format(k=k)) | ||
| # NOTE: tokenize.Name is not a public constant | ||
| # error: Module has no attribute "Name" [attr-defined] | ||
| if not re.match("^" + tokenize.Name + "$", k): # type: ignore |
Member
There was a problem hiding this comment.
Maybe worth considering tokenize.Name to \w+; it hasn't changed in 9 years:
https://github.com/python/cpython/blob/305189ecdc8322c22879a04564cad5989f937462/Lib/tokenize.py#L67
Contributor
|
thanks @simonjayhawkins, @WillAyd comment might be worth a followup |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Member
Author
The ignore was removed in #36012, since Name was added to the stub for tokenize. I don't think a follow-up now needed or we need to change our usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken off #28339