STY: Underscores for long numbers #30166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
lgtm if green |
topper-123
reviewed
Dec 9, 2019
Member
|
See also the comments in #30169 (comment) |
Contributor
|
yeah, I agree with @jorisvandenbossche (underscores only for 7+ digits), though I like having underscores in tests, as it helps when reading the tests. |
|
Hello @MomIsBestFriend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-10 11:47:05 UTC |
ShaharNaveh
force-pushed
the
STY-underscores-batch-1
branch
from
e83db1f to
35a4301
Compare
topper-123
approved these changes
Dec 10, 2019
Contributor
topper-123
left a comment
topper-123
left a comment
There was a problem hiding this comment.
LGTM and can be merged when green.
Member
|
Thanks @MomIsBestFriend |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff