Skip to content

TYP: Ignore remaining mypy errors for pandas\tests\* #36724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020
Merged

TYP: Ignore remaining mypy errors for pandas\tests\* #36724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,9 @@ def unique_nulls_fixture(request):
# ----------------------------------------------------------------
# Classes
# ----------------------------------------------------------------
@pytest.fixture(params=[pd.Index, pd.Series], ids=["index", "series"])
@pytest.fixture(
params=[pd.Index, pd.Series], ids=["index", "series"] # type: ignore[list-item]
)
def index_or_series(request):
"""
Fixture to parametrize over Index and Series, made necessary by a mypy
Expand Down
9 changes: 7 additions & 2 deletions pandas/tests/window/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ def nopython(request):


@pytest.fixture(
params=[pytest.param("numba", marks=td.skip_if_no("numba", "0.46.0")), "cython"]
params=[
pytest.param(
"numba", marks=td.skip_if_no("numba", "0.46.0")
), # type: ignore[list-item]
"cython",
]
)
def engine(request):
"""engine keyword argument for rolling.apply"""
Expand Down Expand Up @@ -327,7 +332,7 @@ def halflife_with_times(request):
"float64",
"m8[ns]",
"M8[ns]",
pytest.param(
pytest.param( # type: ignore[list-item]
"datetime64[ns, UTC]",
marks=pytest.mark.skip(
"direct creation of extension dtype datetime64[ns, UTC] "
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ ignore_errors=True
[mypy-pandas.tests.*]
check_untyped_defs=False

[mypy-pandas.conftest,pandas.tests.window.conftest]
ignore_errors=True

[mypy-pandas._testing]
check_untyped_defs=False

Expand Down