BUG: Fix sort_values bug that creates unprintable object #39464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zitorelova! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-03 14:54:59 UTC |
zitorelova
force-pushed
the
sort_values_bug
branch
from
e330b64 to
4f0d461
Compare
Member
|
needs a test |
jreback
requested changes
Feb 2, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
pls add a test and a whatsnew note in reshaping bug fixes for 1.3
jreback
requested changes
Feb 3, 2021
| n_rows = 4 | ||
|
|
||
| random_state = np.random.RandomState(seed=42) | ||
| test_dict = { |
Contributor
There was a problem hiding this comment.
can you just use a fixed input, so we can directly use assert_frame_equal on the results and compare it exactly.
Contributor
Author
There was a problem hiding this comment.
I've simplified the test so that it only uses fixed inputs.
zitorelova
force-pushed
the
sort_values_bug
branch
from
6f2fdb3 to
47f970a
Compare
jreback
reviewed
Feb 3, 2021
Contributor
|
precommit is failing |
Contributor
Author
|
precommit is passing now |
Contributor
Author
|
Seems to be a |
jreback
approved these changes
Feb 4, 2021
Contributor
|
thanks @zitorelova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occurs when sorting on columns and the
ignore_indexparameter is set toTrue.sort_valuestries to refit the index after the columns have been sorted resulting in a corrupted dataframe.