Skip to content

TST: raising ValueError when inserting one dataframe in another #42831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2021
Merged

TST: raising ValueError when inserting one dataframe in another #42831

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
46c994c
TST: raising ValueError when inserting one dataframe in another
debnathshoham Jul 31, 2021
c5f17ac
added GH issue reference
debnathshoham Jul 31, 2021
45464d7
rev msg
debnathshoham Aug 1, 2021
785283e
included both msgs
debnathshoham Aug 4, 2021
078165a
updated
debnathshoham Aug 4, 2021
f7f0590
Update test_insert.py
debnathshoham Aug 4, 2021
242da55
Update test_insert.py
debnathshoham Aug 4, 2021
5e7c49c
Update test_insert.py
debnathshoham Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pandas/tests/frame/indexing/test_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,13 @@ def test_insert_item_cache(self, using_array_manager):
ser.values[0] = 99

assert df.iloc[0, 0] == df[0][0]

def test_insert_frame(self):
Copy link
Member

@phofl phofl Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test is broken

Copy link
Contributor Author

@debnathshoham debnathshoham Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very confused. I am getting a seperate error message on my local.

Copy link
Member

@phofl phofl Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci error is correct, you will have to debug locally why it is not raised for you

Copy link
Contributor Author

@debnathshoham debnathshoham Aug 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the error msg, but this is also failing. Would need some help, how same error raises multiple error msgs

# GH#42403
df = DataFrame({"col1": [1, 2], "col2": [3, 4]})
msg = (
"Expected a 1D array, got an array with shape "
r"\(2, 2\)|Wrong number of items passed 2, placement implies 1"
)
with pytest.raises(ValueError, match=msg):
df.insert(1, "newcol", df)