Skip to content

TST: GH34037 add test for type error when using parameter 'min_period' #42940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

TST: GH34037 add test for type error when using parameter 'min_period' #42940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad20e7
TST: GH34037 add test for type error when using parameter 'min_period'
horaceklai Aug 8, 2021
5c61723
Merge remote-tracking branch 'upstream/master' into test-min_period
horaceklai Aug 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,3 +2407,15 @@ def test_datetime_categorical_multikey_groupby_indices():
("c", Timestamp("2018-03-01 00:00:00")): np.array([2]),
}
assert result == expected


def test_rolling_wrong_param_min_period():
# GH34037
name_l = ["Alice"] * 5 + ["Bob"] * 5
val_l = [np.nan, np.nan, 1, 2, 3] + [np.nan, 1, 2, 3, 4]
test_df = DataFrame([name_l, val_l]).T
test_df.columns = ["name", "val"]

result_error_msg = r"__init__\(\) got an unexpected keyword argument 'min_period'"
with pytest.raises(TypeError, match=result_error_msg):
test_df.groupby("name")["val"].rolling(window=2, min_period=1).sum()