BUG: Fix metadata propagation in reductions #53542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10947
to
+10948
| if isinstance(result, Series): | ||
| result = result.__finalize__(self, method="any") |
Contributor
There was a problem hiding this comment.
Is this only not a series when axis=None? Or are there other cases where a DataFrame can be reduced to a scaler?
I'd slightly prefer if axis is not None to this isinstance.
Contributor
Author
There was a problem hiding this comment.
Probably, but mypy won't be able to figure out that result is a Series without an isinstance/cast, though.
mroeschke
reviewed
Jul 31, 2023
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Aug 1, 2023
Member
|
Thanks @lithomas1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.