TST: add a test with freq=1MS to increase coverage of shift #54211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MarcoGorelli, , could you please take a look at this pr? |
MarcoGorelli
added
Datetime
MarcoGorelli
approved these changes
Jul 21, 2023
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
Always happy to see coverage increase, thanks!
| shifted = df.shift(freq="1MS") | ||
| expected = DataFrame( | ||
| {"x": [1, 2, 3]}, | ||
| index=date_range(start="02/01/2000", end="02/01/2000", periods=3), |
Member
There was a problem hiding this comment.
this is fine here, but in the future, I'd suggest using 2000-02-01 format, it's less ambiguous, whereas 02/01/2000 means different things in different parts of the world
Contributor
Author
There was a problem hiding this comment.
Thank you, I will use 2000-02-01 format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #52064
Added a test with
freq=1MSto increase coverage ofshift. The reason: existing tests don't cover a case if the index of a DataFrame is aDatetimeIndex.