STY: Enable ruff ambiguous unicode character #54330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested review from
MarcoGorelli,
attack68,
datapythonista and
rhshadrach
as code owners
rhshadrach
requested changes
Jul 31, 2023
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Nice - never even thought about these sneaking in here when reviewing a PR.
| (DataFrame([["abc", "def", "ghi"]], columns=["X", "Y", "Z"]), "ascii"), | ||
| (DataFrame(5 * [[123, "你好", "世界"]], columns=["X", "Y", "Z"]), "gb2312"), | ||
| ( | ||
| DataFrame(5 * [[123, "Γειά σου", "Κόσμε"]], columns=["X", "Y", "Z"]), |
| # GH 21241, 21118 | ||
| (Series(["abc", "def", "ghi"], name="X"), "ascii"), | ||
| (Series(["123", "你好", "世界"], name="中文"), "gb2312"), | ||
| (Series(["123", "Γειά σου", "Κόσμε"], name="Ελληνικά"), "cp737"), |
pandas/tests/strings/test_strings.py
Outdated
Comment on lines
229
to
230
| # 0xFF13: ３ Em 3 # noqa: RUF003 | ||
| ser = Series(["A", "3", "¼", "★", "፸", "3", "four"], dtype=any_string_dtype) |
Member
There was a problem hiding this comment.
Seems like the comment above is indicating this one shouldn't be changed?
Member
There was a problem hiding this comment.
Same remark for the rest of the changes in this file.
Member
Author
There was a problem hiding this comment.
Good catch. Added noqas here
Member
|
Thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.