DOC: Fixing EX01 - Added examples #54351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
Aug 1, 2023
| .. plot:: | ||
| :context: close-figs | ||
| >>> pd.plotting.register_matplotlib_converters() |
Member
There was a problem hiding this comment.
Can we remove this line? I think pandas should do it automatically
Could we explain that pandas does this automatically?
Member
There was a problem hiding this comment.
And then note that if we manually prevent it from happening, then plotting for period fails
Member
Author
There was a problem hiding this comment.
I added the first line because of Sphinx local fail.
MarcoGorelli
approved these changes
Aug 1, 2023
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
Cool, looks good to me on green!
Maybe we can reuse same example for deregister_matplotlib_converters - it's close enough, and it enough to teach what the purpose of the method is
Member
Author
|
|
Member
Author
|
It's green |
mroeschke
approved these changes
Aug 1, 2023
Member
|
Thanks @DeaMariaLeon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #37875
Sphinx acting weird locally :-/