-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
DOC: update information of parameter value_name of pandas.melt #54828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 7 commits into
pandas-dev:main
from
thiagogquinto:54715-pandas.melt_docs
Aug 30, 2023
Merged
DOC: update information of parameter value_name of pandas.melt #54828
mroeschke
merged 7 commits into
pandas-dev:main
from
thiagogquinto:54715-pandas.melt_docs
Aug 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@myles could you take a look in this PR, please? I know it's a small thing, but I am new in the open source community then I started with something simple. |
samukweku
reviewed
Aug 29, 2023
mroeschke
reviewed
Aug 29, 2023
pandas/core/shared_docs.py
Outdated
| ``frame.columns.name`` or 'variable'. | ||
| value_name : scalar, default 'value' | ||
| Name to use for the 'value' column. | ||
| Name to use for the 'value' column, can't be an existing column name. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Name to use for the 'value' column, can't be an existing column name. | |
| Name to use for the 'value' column, can't be an existing column label. |
Member
|
Thanks @thiagogquinto |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
…s-dev#54828) * doc: updating explanation of parameter value_name to prevent error * update wording for clarity * fix spell * update with the suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update developed was to add the information of no repeating an already existing column name.