Skip to content

Conversation

@thiagogquinto
Copy link
Contributor

@thiagogquinto thiagogquinto commented Aug 28, 2023

  • closes DOC:  #54715
  • Pre-commit and python3 scripts/validate_docstrings.py pandas.melt were executed with no mistakes

The update developed was to add the information of no repeating an already existing column name.

@thiagogquinto
Copy link
Contributor Author

@myles could you take a look in this PR, please? I know it's a small thing, but I am new in the open source community then I started with something simple.

``frame.columns.name`` or 'variable'.
value_name : scalar, default 'value'
Name to use for the 'value' column.
Name to use for the 'value' column, can't be an existing column name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Name to use for the 'value' column, can't be an existing column name.
Name to use for the 'value' column, can't be an existing column label.

@mroeschke mroeschke added the Docs label Aug 29, 2023
@mroeschke mroeschke added this to the 2.2 milestone Aug 30, 2023
@mroeschke mroeschke merged commit b7319c1 into pandas-dev:main Aug 30, 2023
@mroeschke
Copy link
Member

Thanks @thiagogquinto

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
…s-dev#54828)

* doc: updating explanation of parameter value_name to prevent error

* update wording for clarity

* fix spell

* update with the suggested change
@thiagogquinto thiagogquinto deleted the 54715-pandas.melt_docs branch September 22, 2023 22:02
@thiagogquinto thiagogquinto restored the 54715-pandas.melt_docs branch September 22, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC:

3 participants