DOC: Added alternative examples for deprecated DataFrame.last() #55166
Conversation
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Hestaron. I added couple of comments, personal preferences, let me know if you disagree with them.
| .. deprecated:: 2.1.0 | ||
| Please create a mask and filter using `.loc` instead | ||
| Please create a mask and filter using `.loc` instead. | ||
| See examples for both cases. |
There was a problem hiding this comment.
Can you just write See examples below. instead? In the same line probably better.
| 2018-04-13 3 | ||
| 2018-04-15 4 | ||
| This is an alternative example. If you are not sure the index is sorted. |
There was a problem hiding this comment.
Can you add this example at the very end of the docstring please? I think the comment below should stay and give context to the original last example.
I know we're adding this because of the deprecation, but I'd personally prefer to phrase this as This is equivalent to...
datapythonista
changed the title
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
4 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.