Skip to content

TST: Don't call gc.collect for plotting tests #55267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

TST: Don't call gc.collect for plotting tests #55267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pandas/tests/io/formats/style/test_matplotlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import gc

import numpy as np
import pytest

Expand Down Expand Up @@ -33,8 +31,6 @@ def mpl_cleanup():
mpl_units.registry.clear()
mpl_units.registry.update(orig_units_registry)
plt.close("all")
# https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.6.0.html#garbage-collection-is-no-longer-run-on-figure-close # noqa: E501
gc.collect(1)


@pytest.fixture
Expand Down
4 changes: 0 additions & 4 deletions pandas/tests/plotting/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import gc

import numpy as np
import pytest

Expand All @@ -25,8 +23,6 @@ def mpl_cleanup():
mpl_units.registry.clear()
mpl_units.registry.update(orig_units_registry)
plt.close("all")
# https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.6.0.html#garbage-collection-is-no-longer-run-on-figure-close # noqa: E501
gc.collect(1)


@pytest.fixture
Expand Down
3 changes: 0 additions & 3 deletions pandas/tests/plotting/frame/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
date,
datetime,
)
import gc
import itertools
import re
import string
Expand Down Expand Up @@ -2050,8 +2049,6 @@ def test_memory_leak(self, kind):

# have matplotlib delete all the figures
plt.close("all")
# force a garbage collection
gc.collect()
assert ref() is None

def test_df_gridspec_patterns_vert_horiz(self):
Expand Down