REF: implement ParseState #55617
Merged
REF: implement ParseState #55617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Oct 23, 2023
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
minor comment but generally lgtm
pandas/_libs/tslibs/strptime.pxd
Outdated
| cdef bint parse_today_now(str val, int64_t* iresult, bint utc) | ||
|
|
||
|
|
||
| cdef class ParseState: |
Member
There was a problem hiding this comment.
I think we should call this DateTimeParseState; helps to disambiguate it in case it ends up intertwined with any other type of parser
mroeschke
approved these changes
Oct 23, 2023
Member
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the near future, the state being tracked in array_to_datetime and array_strptime will include a resolution (xref #55564). This implements a ParseState object to de-duplicate tracking, validation, and updating.